On Thu, Dec 24, 2015 at 09:35:52AM -0600, Timur Tabi wrote: > On Thu, Dec 24, 2015 at 9:05 AM, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxxx> wrote: > > On Thu, Dec 24, 2015 at 09:03:12AM -0600, Timur Tabi wrote: > >> On Thu, Dec 24, 2015 at 12:54 AM, Huang Shijie <shijie.huang@xxxxxxx> wrote: > >> > My kernel cmdline: > >> > console=ttyAMA0,115200 earlycon=pl011,0x7ff80000 root=/dev/sda1 rootwait verbose debug sky2.mac_address=0x00,0x02,0xF7,0x00,0x63,0x3C dtb=r1a57.dtb > >> > >> earlycon is broken with Russell's patches. My patch fixes it, but > >> only for standard pl011 devices. > > > > No, it shouldn't be. Earlycon uses pl011_putc() which remains exactly > > the same as it was before these patches. > > while (readl(port->membase + REG_FR) & UART01x_FR_TXFF) > > is broken because REG_FR is equal to 1. Patch 4, which changes to the REG_* stuff, does not (explicitly) touch this because it _will_ break stuff. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html