On Sun, Dec 20, 2015 at 8:11 PM, Matwey V. Kornilov <matwey@xxxxxxxxxx> wrote: > 2015-12-20 19:41 GMT+03:00 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: >> On Sat, Dec 12, 2015 at 1:23 PM, Matwey V. Kornilov <matwey@xxxxxxxxxx> wrote: >>> Implementation of software emulation of RS485 direction handling is based >>> on omap_serial driver. >>> Before and after transmission RTS is set to the appropriate value. >>> >>> Note that before calling serial8250_em485_init the caller has to >>> ensure that UART will interrupt when shift register empty. Otherwise, >>> emultaion cannot be used. >>> >>> Both serial8250_em485_init and serial8250_em485_destroy are >>> idempotent functions. >> >> Just nitpick suggesting to rename both struct and field: >> >> struct uart_8250_rs485em *rs485em; > > Why not > > struct uart_8250_em485 *em485; > > to be consistent with function name suffix? I'm fine with that as well. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
