Hi Noam, On Thu, Dec 10, 2015 at 04:33:39PM +0000, Noam Camus wrote: > Please see > https://lkml.org/lkml/2015/8/3/806 > Why I added private accessors. Greg is not saying anything about the iotype checking there? Looks more like confusion about what exactly is that patch trying to achieve. I think Greg just thought you moved the writel call from the beginning of the function to be called later inside the "else" condition. You need to start your series with a patch where you just separate the lcr checking to its own function and follow that with patches where you introduce the big-endian support. I think this is also what Andy told you. Use the diff I gave you. One more thing that I forgot to comment before: s/dw8250_check_LCR/dw8250_check_lcr/ Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
