On Wed, 2015-11-18 at 18:19 +0800, Eryu Guan wrote: > Hi, > > I hit the following build error on PPC64 host, v4.4-rc1 kernel. > > ERROR: "fsl8250_handle_irq" [drivers/tty/serial/of_serial.ko] > undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > and I bisected to commit d43b54d269d2 ("serial: Enable Freescale 16550 > workaround on arm"). > > From the commit log it seems that PPC host doesn't need > fsl8250_handle_irq, it's there for ARM. So I tested this patch and build > works fine, but I'm not sure if it's a correct fix. The correct fix is to export fsl8250_handle_irq(). A patch for that was sent by Arnd Bergman on Monday. fsl8250_handle_irq() is used on PPC, it's just that we don't usually use of_serial.c on the PPC chips where this is relevant. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html