Hi,
I hit the following build error on PPC64 host, v4.4-rc1 kernel.
ERROR: "fsl8250_handle_irq" [drivers/tty/serial/of_serial.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
and I bisected to commit d43b54d269d2 ("serial: Enable Freescale 16550
workaround on arm").
>From the commit log it seems that PPC host doesn't need
fsl8250_handle_irq, it's there for ARM. So I tested this patch and build
works fine, but I'm not sure if it's a correct fix.
Thanks,
Eryu
---
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
index de50296..abfeed8 100644
--- a/drivers/tty/serial/of_serial.c
+++ b/drivers/tty/serial/of_serial.c
@@ -154,7 +154,7 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
break;
}
- if (IS_ENABLED(CONFIG_SERIAL_8250_FSL) &&
+ if (IS_ENABLED(CONFIG_SERIAL_8250_FSL) && !IS_ENABLED(CONFIG_PPC) &&
(of_device_is_compatible(np, "fsl,ns16550") ||
of_device_is_compatible(np, "fsl,16550-FIFO64")))
port->handle_irq = fsl8250_handle_irq;
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
