On 11/05/2015 08:44 PM, Peter Hurley wrote:
Or better yet, for sbsa32 earlycon, just use the existing port type constructs.
So,
earlycon=pl011,mmio32,0x3ced1000
which will set port->iotype to UPIO_MEM32, which in turn can be used to select
the correct i/o width in pl011_putc().
That's a great idea. But why aren't we using it for pl011_write()?
static void pl011_write(unsigned int val, const struct uart_amba_port *uap,
unsigned int reg)
{
void __iomem *addr = uap->port.membase + pl011_reg_to_offset(uap, reg);
if (uap->port.iotype == UPIO_MEM32)
writel(val, addr);
else
writew(val, addr);
}
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
