On 11/05/2015 09:00 PM, Timur Tabi wrote: > Peter Hurley wrote: >> Perhaps I wasn't clear enough in my previous comments regarding this >> approach; I see no benefit to re-using the pl011 earlycon definition. >> Just define a completely new earlycon for sbsa32 (and zte): >> >> EARLYCON_DECLARE(sbsa32, sbsa32_early_console_setup); >> >> Example: >> earlycon=sbsa32,0x3ced1000 > > Sounds like six of one, half-dozen of another. But I'm happy to modify my patch accordingly. It will avoid the strcmp, but I'm not sure it will reduce the actual number of lines of code. Or better yet, for sbsa32 earlycon, just use the existing port type constructs. So, earlycon=pl011,mmio32,0x3ced1000 which will set port->iotype to UPIO_MEM32, which in turn can be used to select the correct i/o width in pl011_putc(). Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
