Hi Timur, On 02/11/15 13:27, Timur Tabi wrote: > Andre Przywara wrote: >> * to support UARTs with different register offsets (ZTE) >> * to support a different bus access width (16 bits vs. 32 bits) > > How exactly does this patch provide this? The code is still calling a > fixed function. How will the code dynamically call a 32-bit version > instead of a 16-bit version on platforms that need it? This patch doesn't, I was just enumerating possible extensions which will become much easier now that we don't have to patch every single call site for such a change (to give rationale for this refactoring). Changing the access width is now a simple change in those two functions, and since you have the struct uart_amba_port available, you can access any field in there to determine your desired access width. As it says on the tin: it's a draft. Feel free to extend it to a proper series ;-) Cheers, Andre. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html