Hi, there has been some discussion on how to integrate support for the ZTE ZX296702 UART, which is very similar to the PL011, but (among other deviations) has its registers at different offsets from the base address. Previous patches on the list [1] were reworking the whole of the PL011 driver, creating extra churn for all architecture compliant implementations. This sketch introduces register accessor wrappers in patch 1, which are useful for other things as well later. Ideally the generated code should look identical after this one, given the compiler properly inlines the accessor functions. Based on that patch 2 then introduces a mapping table just for the ZTE UART, which redirects the original PL011 register offsets to the shifted positions on the ZTE UART. The impact on all other implementations are kept minimal, actually if the CONFIG_ symbol for that SoC is not defined, there should be no code difference compared to the state before. I don't have access to the ZTE UART hardware, so could not test this (this patch set is not complete anyway), but I quickly tested for regressions on a Juno, which seems to work fine for me. I provide these patches as a base for discussion and for future, proper support patches. Do these make sense to anyone? Is this the way to go for the ZTE UART implementation? Any comments are appreciated. Cheers, Andre. [1] http://marc.info/?l=linux-serial&m=143832897928885&w=2 Andre Przywara (2): drivers: serial: PL011: refactor register access drivers: serial: PL011: [DRAFT] implement register diverson for ZTE UART drivers/tty/serial/amba-pl011.c | 246 +++++++++++++++++++++++----------------- include/linux/amba/serial.h | 10 ++ 2 files changed, 155 insertions(+), 101 deletions(-) -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
