On Fri, Jul 31, 2015 at 2:49 AM, Jun Nie <jun.nie@xxxxxxxxxx> wrote: > > > +enum reg_idx { > + REG_DR = UART01x_DR, > + REG_RSR = UART01x_RSR, > + REG_ST_DMAWM = ST_UART011_DMAWM, > + REG_FR = UART01x_FR, > + REG_ST_LCRH_RX = ST_UART011_LCRH_RX, > + REG_ILPR = UART01x_ILPR, > + REG_IBRD = UART011_IBRD, > + REG_FBRD = UART011_FBRD, > + REG_LCRH = UART011_LCRH, > + REG_CR = UART011_CR, > + REG_IFLS = UART011_IFLS, > + REG_IMSC = UART011_IMSC, > + REG_RIS = UART011_RIS, > + REG_MIS = UART011_MIS, > + REG_ICR = UART011_ICR, > + REG_DMACR = UART011_DMACR, > +}; I'm not a fan of this patchset at all. It seems the whole purpose is to support a specific UART device that really isn't that similar to the PL011. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html