On Wed, Aug 5, 2015 at 2:54 AM, Qipeng Zha <qipeng.zha@xxxxxxxxx> wrote:
> This patch is to revert below workaround patch
> 33acbb82695f ("serial: 8250_dw: Report CTS asserted for auto flow")
>
> Since Designware 8250 controller can manage flow control automatically,
> and serial core support auto CTS mode, so it's better to just enable
> auto CTS mode for this controller to solve issue reported in workaround
> patch.
>
> Signed-off-by: Huiquan Zhong <huiquan.zhong@xxxxxxxxx>
> Signed-off-by: Qipeng Zha <qipeng.zha@xxxxxxxxx>
>
> ---
> change in V2:
> update subject line and commit message.
> ---
> drivers/tty/serial/8250/8250_dw.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
Qipeng,
Commit 391f93f2ec9f ("serial: core: Rework hw-assisted flow control support")
along with your "serial: 8250: Auto CTS control by HW if AFE enabled" patch
that is under review should eliminate the need for my workaround.
http://www.spinics.net/lists/linux-serial/msg18292.html
This commit message, however, is confusing. Why not something like:
Since the serial core is informed that this device is doing automatic
flow control, it is not necessary to alter CTS and DCTS of the MSR as
the core no longer attempts stop the port in uart_handle_cts_change().
Thanks,
Tim Kryger
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
