> -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: 2015年7月29日 16:46 > To: Wang Shenwei-B38339 > Cc: Greg Kroah-Hartman; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-serial@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 1/1] Serial: imx: add dev_pm_ops to support suspend to > ram/disk > > On Wed, Jul 29, 2015 at 6:41 PM, Shenwei Wang <Shenwei.Wang@xxxxxxxxxxxxx> > wrote: > > >> clk_enable() may fail, so you should check its return value. > > > > The check seems a little superfluous because the failure condition for > > clk_enable is (clk == NULL || IS_ERR(clk)) Once this function is > > called which means the initialization of the driver is successful. > > Not superfluos. You can't assume that clk_enable() will always be successful. > Better check its return value. I am very interesting to know if you could provide an example condition that may cause clk_enable failed in this callback function? Regards, Shenwei ��.n��������+%������w��{.n�����{��ǫ����{ay� ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��
