On Wed, Jul 29, 2015 at 6:41 PM, Shenwei Wang <Shenwei.Wang@xxxxxxxxxxxxx> wrote: >> clk_enable() may fail, so you should check its return value. > > The check seems a little superfluous because the failure condition for clk_enable is > (clk == NULL || IS_ERR(clk)) > Once this function is called which means the initialization of the driver is successful. Not superfluos. You can't assume that clk_enable() will always be successful. Better check its return value. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
