> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: 2015年7月23日 19:37 > To: Wang Shenwei-B38339 > Cc: linux-serial@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/1] Serial: imx: add dev_pm_ops to support suspend to > ram/disk > > + sport->saved_reg[4] = readl(sport->port.membase + UFCR); > > + sport->saved_reg[5] = readl(sport->port.membase + UESC); > > + sport->saved_reg[6] = readl(sport->port.membase + UTIM); > > + sport->saved_reg[7] = readl(sport->port.membase + UBIR); > > + sport->saved_reg[8] = readl(sport->port.membase + UBMR); > > + sport->saved_reg[9] = readl(sport->port.membase + IMX21_UTS); > > + clk_disable(sport->clk_ipg); > > + > > + pr_debug("0x%p (%d)\r\n", sport->port.membase, sport->port.line); > > You have a struct device, please use dev_dbg() instead. Adopted in PATCH v2. > > > + > > + return 0; > > +} > > + > > + writel(sport->saved_reg[2], sport->port.membase + UCR3); > > + writel(sport->saved_reg[3], sport->port.membase + UCR4); > > + clk_disable(sport->clk_ipg); > > + > > + pr_debug("0x%p (%d)\r\n", sport->port.membase, sport->port.line); > > Same here, please use dev_dbg() Adopted in PATCH v2. Thanks, Shenwei ?韬{.n?????%??檩??w?{.n???{炳谦??{ay????j?f＂??????_璁(????"??m???G??⒏??璀?ｘ??
