Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") makes the flags argument to devm_gpiod_get_optional mandatory but does not update all users. This results in the following build error. drivers/tty/serial/etraxfs-uart.c:933:16: error: too few arguments to function ‘devm_gpiod_get_optional’ Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> --- drivers/tty/serial/etraxfs-uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/etraxfs-uart.c b/drivers/tty/serial/etraxfs-uart.c index a57301a6fe42..e35a19b214d5 100644 --- a/drivers/tty/serial/etraxfs-uart.c +++ b/drivers/tty/serial/etraxfs-uart.c @@ -930,10 +930,10 @@ static int etraxfs_uart_probe(struct platform_device *pdev) up->irq = irq_of_parse_and_map(np, 0); up->regi_ser = of_iomap(np, 0); - up->dtr_pin = devm_gpiod_get_optional(&pdev->dev, "dtr"); - up->dsr_pin = devm_gpiod_get_optional(&pdev->dev, "dsr"); - up->ri_pin = devm_gpiod_get_optional(&pdev->dev, "ri"); - up->cd_pin = devm_gpiod_get_optional(&pdev->dev, "cd"); + up->dtr_pin = devm_gpiod_get_optional(&pdev->dev, "dtr", GPIOD_ASIS); + up->dsr_pin = devm_gpiod_get_optional(&pdev->dev, "dsr", GPIOD_ASIS); + up->ri_pin = devm_gpiod_get_optional(&pdev->dev, "ri", GPIOD_ASIS); + up->cd_pin = devm_gpiod_get_optional(&pdev->dev, "cd", GPIOD_ASIS); up->port.dev = &pdev->dev; cris_serial_port_init(&up->port, dev_id); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html