RE: [PATCH 2/2] [Telephony/Mux]: n_gsm: Add Debug define for extra levels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

Thank you to spend (waste) your time to help/support me to try to push the Intel Mux patches. I requested the support from the Intel kernel team and read a long list of documents related to the good process to submit the patch to the community reviewers, but didn't find the best tutorial that could avoid to disturb you and your colleagues. Sorry for that again.

To explain what I would like to do: I initially propose a patch that contains several code modifications to improve debugging and robustness of the mux. According to you, reviewers, this patch need to be split into a multiple patches set easy to be reviewed that I understand. 
Now I am facing the following issue: how to propose this list of patches one by one in order to get your approval for each of them, but by indicating there are dependency between themselves ? I tried the patch number, but you rejected it because of the reference lack to the previous patch. I can't push all of them in only one submission proposal, because I am building them one by one (There were initially 4 authors who didn't provide a lot of explanations for their contributions. Then I just need to split and understand what they did to justify).

Anyway, what could be your proposal to propose this set of dependent patches for review ?
For the email issue, I will use "git send-email" that  should solve the wrapped-lines issue.

Thank you
Regards/Cordialement

Gwenn BOURREE

TEL:+33567346108
Intel Mobile Communication France SAS
4 rue du Dr Grynfogel
Toulouse BAS1
France


 

-----Original Message-----
From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] 
Sent: Monday, July 6, 2015 4:24 PM
To: Bourree, Gwenn
Cc: jslaby@xxxxxxx; marcel@xxxxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/2] [Telephony/Mux]: n_gsm: Add Debug define for extra levels

On Mon, Jul 06, 2015 at 02:40:16PM +0200, Gwenn Bourrée wrote:
> Improve the debug print out by adding extra debug levels that allows 
> to be verbose and ease the debugging. For example, they allow to 
> display the content of the TX or RX frames, the protocol data or/and 
> the content of the frames.The new levels macros are clearer to 
> understand than the previous numbers.
> 
> Signed-off-by: Gwenn Bourree <gwenn.bourree@xxxxxxxxx>
> ---
>  drivers/tty/n_gsm.c | 40 ++++++++++++++++++++++++----------------
>  1 file changed, 24 insertions(+), 16 deletions(-)

No patch 1/2?

Ok, this is enough, sorry.  You have access to the resources internal to Intel for how to properly create and submit a kernel patch.  I'm now going to require you to use them.  Don't submit any more patches until you work with Intel's internal developers and get their signed-off-by on the patches, proving that they are acceptable and in a correct format that can be applied.  If not, I'm just going to keep ignoring them, as you are wasting our time.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux