RE: [PATCH v5 1/2] sc16is7xx: spi interface is added

[Rama Kiran Kumar Indrakanti <indrakanti_ram@xxxxxxxxxxx>]

> On Fri, 22 May 2015 17:14:15 +0530, Rama Kiran Kumar Indrakanti wrote:
>> spi interface for sc16is7xx is added along with Kconfig flag
>> to enable spi or i2c, thus in a instance we can have either
>> spi or i2c or both, in sync to the hw.
>>
>> Signed-off-by: Rama Kiran Kumar Indrakanti <indrakanti_ram@xxxxxxxxxxx>
>> ---
>>
>> Changes in v2:
>> -Added seprate flags for i2c and spi
>> -Added space in the comments lines
>> -Added MODULE_ALIAS for spi interface
>>
>> Changes in v3:
>> -Added Kconfig to avoid build errors
>> -Modified Makefile to refelect Kconfig changes
>>
>> Changes in v4:
>> -Change to Kconig to avoid build errors
>>
>> Changes in V5:
>> -Change in Kconfig to build as module
>> -Change in the init section, to support module build
>> ---
>> drivers/tty/serial/Kconfig | 43 +++++++++++++----
>> drivers/tty/serial/Makefile | 2 +-
>> drivers/tty/serial/sc16is7xx.c | 105 ++++++++++++++++++++++++++++++++++++++++-
>> 3 files changed, 140 insertions(+), 10 deletions(-)
>
> Patch 2/2 got lost somehow? Besides there is a warning:
>
Yes, need to check where its lost, would resend it any how..

> ../drivers/tty/serial/sc16is7xx.c: In function 'sc16is7xx_init':
> ../drivers/tty/serial/sc16is7xx.c:1342:3: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'int' [-Wformat=]
> pr_err("failed to init sc16is7xx spi --> %ld\n", ret);
>
> Other than that looks fine!
Okay, will check this..

> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
 		 	   		  ˙ôčş{.nÇ+?ˇ?Ž?­?+%?Ë˙ąéÝśĽ?w˙ş{.nÇ+?ˇĽ?{ąţÇŤ?Š˙?{ayşĘ?Ú?ë,j­˘fŁ˘ˇh??ď?ę˙?ęçz_čŽ(­é???ݢj"?úśm§˙˙žŤţGŤ?é˙˘¸??¨č­Ú&Łř§~?á