Re: [PATCH 1/1] tty, serial, 8250: to avoid recv fifo overrun, read rx fifo during xmit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/28/2015 02:17 PM, Greg KH wrote:
> On Tue, Apr 28, 2015 at 10:44:31AM -0700, Prasad Koya wrote:
>> Hi Greg
>>
>> Actually, there is no change wrt sysrq handling. This note mentions that
>> patch handles input overrun in all cases except sysrq.
>>
>> Peter Hurley felt this is such a use case that not everyone may run into.
>> Hence he suggested to put this under CONFIG option.
> 
> How would a distro / user know what to do here?  Why would they ever
> disable this?

I would hope a distro would never enable it.

> Please let's make this automatic, and work properly, no configuration
> option should be needed, _IF_ this doesn't cause a problem for people
> with normal systems.

I feel the effort and trade-offs required to make this automatic and
bullet-proof is simply not worth it.

For example, new data that's received while in the middle of a 
printk() may trigger a GPF_ATOMIC memory allocation.

That could cause real problems under the wrong circumstances.

> If it does cause problems, then a config option is also not the correct
> response, as that's not how to manage this type of thing.

What's the other method? Please don't say "module parameter".

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux