On Thu, 26 Mar 2015 22:37:01 +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 17, 2015 at 03:57:00PM +0100, Jakub Kiciński wrote: > > On Tue, 17 Mar 2015 10:45:26 -0400 (EDT), Jon Ringle wrote: > > > This makes sense. I did have to fix up my user space app to set > > > SER_RS485_RTS_ON_SEND after applying this patch. > > > > Yes, perhaps I should have mentioned that this makes the ioctl return > > -EINVAL when neither of SER_RS485_RTS_*_SEND flags is set. This > > definitely has potential to break people's apps. Let's see if anyone > > else has an opinion on this. > > Yes, don't break people's apps. Do you mean it would be OK if I ignore the incorrect combinations instead of returning -EINVAL or is any user-visible change in the behaviour of the driver unacceptable? -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
