On Tue, 17 Mar 2015 10:45:26 -0400 (EDT), Jon Ringle wrote: > This makes sense. I did have to fix up my user space app to set > SER_RS485_RTS_ON_SEND after applying this patch. Yes, perhaps I should have mentioned that this makes the ioctl return -EINVAL when neither of SER_RS485_RTS_*_SEND flags is set. This definitely has potential to break people's apps. Let's see if anyone else has an opinion on this. I am also very tempted to remove rs485.delay_rts_*_send mdelays from this driver and return -EINVAL in a similar fashion when there are set. Normally when the driver is responsible for wiggling the GPIO/RTS line mdelays can indeed impact when the lines change state but in sc16is7xx case transitions are controlled by HW and there is nothing the driver can do about the the relation between TX/RX mode switch and state of RTS lines... Do you agree? -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
