Re: [PATCH] uart: pl011: Add support to ZTE uart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/13/2015 01:46 PM, Russell King - ARM Linux wrote:
> On Fri, Mar 13, 2015 at 01:41:02PM -0400, Peter Hurley wrote:
>> I think this would be much cleaner keeping the existing register index
>> symbolic constants and using a remapping LUT with inline i/o accessors.
>>
>> Plus it has the advantage of disallowing certain indexes which are not
>> mapped (rather than an accidental alias).
>>
>> I realize that was not the original model set forth but I don't think
>> the original model contemplated a complete remap.
> 
> In that case, we will want to ensure that we cache the data register
> and flag register iomem pointer in loops, so we don't have to
> constantly reload the base and offsets.
> 
> This code gets run on some fairly slow ARM systems - including entirely
> FPGA based systems.

I would the think the compiler would factor ptr calculations outside
any loop, but maybe not.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux