Hello,
On Fri, Mar 13, 2015 at 12:10:23PM +0300, Dan Carpenter wrote:
> The patch 343fda95481a: "serial: mxs-auart: properly handle
> mctrl_gpio failing" from Feb 12, 2015, leads to the following static
> checker warning:
>
> drivers/tty/serial/mxs-auart.c:1282 mxs_auart_probe()
> warn: statement has no effect 3
>
> drivers/tty/serial/mxs-auart.c
> 1277 platform_set_drvdata(pdev, s);
> 1278
> 1279 ret = mxs_auart_init_gpios(s, &pdev->dev);
> 1280 if (ret) {
> 1281 dev_err(&pdev->dev, "Failed to initialize GPIOs.\n");
> 1282 got out_free_irq;
> ^^^^^^^^^^^^^^^^
> Wot? *goto* and label doesn't exist.
This is already fixed in Greg's tree, so the next next should be better
here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
