Hello Uwe Kleine-König,
The patch 343fda95481a: "serial: mxs-auart: properly handle
mctrl_gpio failing" from Feb 12, 2015, leads to the following static
checker warning:
drivers/tty/serial/mxs-auart.c:1282 mxs_auart_probe()
warn: statement has no effect 3
drivers/tty/serial/mxs-auart.c
1277 platform_set_drvdata(pdev, s);
1278
1279 ret = mxs_auart_init_gpios(s, &pdev->dev);
1280 if (ret) {
1281 dev_err(&pdev->dev, "Failed to initialize GPIOs.\n");
1282 got out_free_irq;
^^^^^^^^^^^^^^^^
Wot? *goto* and label doesn't exist.
1283 }
1284
1285 /*
1286 * Get the GPIO lines IRQ
1287 */
1288 ret = mxs_auart_request_gpio_irq(s);
1289 if (ret)
1290 return ret;
1291
1292 auart_port[s->port.line] = s;
1293
1294 mxs_auart_reset(&s->port);
1295
1296 ret = uart_add_one_port(&auart_driver, &s->port);
1297 if (ret)
1298 goto out_free_gpio_irq;
1299
1300 version = readl(s->port.membase + AUART_VERSION);
1301 dev_info(&pdev->dev, "Found APPUART %d.%d.%d\n",
1302 (version >> 24) & 0xff,
1303 (version >> 16) & 0xff, version & 0xffff);
1304
1305 return 0;
1306
1307 out_free_gpio_irq:
1308 mxs_auart_free_gpio_irq(s);
1309 auart_port[pdev->id] = NULL;
1310 return ret;
1311 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
