Hi Greg and Sören: > > > -#define cdns_uart_readl(offset) ioread32(port->membase + offset) > > > -#define cdns_uart_writel(val, offset) iowrite32(val, > port->membase + offset) > > > +#define cdns_uart_readl(up, reg) ioread32((up)->membase + (reg)) > > > +#define cdns_uart_writel(up, val, reg) iowrite32(val, > (up)->membase + (reg)) > > > > IMHO, we could get rid of this indirection layer completely and just > > directly call io(read|write). > > Yes please, no need for hiding this type of thing everywhere. Got it; my intention was to fix the macros, but if you want to get rid of them altogether, I will create another patch. I would rather use readl()/writel() instead of ioread32()/iowrite32(), same as all the other serial drivers. Would that be okay, or do I overlook something? [I know that ioread32 == readl on ARM, it's just that the semantics is different.] Best regards, Thomas Betker -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
