On Wed, Mar 11, 2015 at 12:17:55PM +0100, Uwe Kleine-König wrote: > Hey Russell, > > On Wed, Mar 11, 2015 at 10:22:09AM +0000, Russell King - ARM Linux wrote: > > On Sun, Mar 08, 2015 at 10:05:29PM +0100, Arnd Bergmann wrote: > > > ARM randconfig build tests found a new error for configurations > > > with COMMON_CLK disabled but HAS_CLK selected by the platform: > > > > > > ERROR: "clk_is_match" [sound/soc/fsl/snd-soc-fsl-spdif.ko] undefined! > > > > > > This moves the declaration around, so this case is covered > > > by the existing static inline helper function. > > > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > > Fixes: c69e182e51d89 ("clk: introduce clk_is_match") > > > ---- > > > BTW, we have a preexisting problem in clk_get_parent, > > > clk_round_rate and clk_set_parent, which I've worked around in > > > my randconfig builds so far. Should we do that the same way? > > > > NAK, as Uwe points out, you didn't address my comment. > You commented on the patch that is c69e182e51d8 ("clk: introduce > clk_is_match") now in next. Arnd just moved this around. *Sigh* Mike - please remove this commit until proper kernel patch process is honoured. We'll have some order here, and mutual respect of fellow kernel developers, rather than people selectively ignoring people. Yes, I realise that it fixes a bug, but it's utterly disgusting that comments on a patch are ignored and it's just picked up irrespective of comments being addressed. If you don't like that, bloody well do a better job. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html