Hello,
On Tue, Mar 10, 2015 at 11:24:24AM -0300, Fabio Estevam wrote:
> Commit 343fda95481a7254f ("serial: mxs-auart: properly handle mctrl_gpio
> failing") introduced the following build error:
>
> CC drivers/tty/serial/mxs-auart.o
> drivers/tty/serial/mxs-auart.c: In function 'mxs_auart_probe':
> drivers/tty/serial/mxs-auart.c:1282:3: error: unknown type name 'got'
>
> Fix it by providing a proper return code.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
> drivers/tty/serial/mxs-auart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index 9abdccf..20a863b 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -1279,7 +1279,7 @@ static int mxs_auart_probe(struct platform_device *pdev)
> ret = mxs_auart_init_gpios(s, &pdev->dev);
> if (ret) {
> dev_err(&pdev->dev, "Failed to initialize GPIOs.\n");
> - got out_free_irq;
> + return ret;
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Hmm, I don't remember this patch. Probably that's because I quickly
closed my editor because there are some obvious problems with this
driver[1]. I think some of them were addressed at some point by Janusz
Uzycki, but I guess the patches don't apply anymore.
Thanks Fabio for cleaning up after me.
Best regards
Uwe
[1]
- it considers 0 to be a valid irq
- it does auart_port[pdev->id] = NULL; in an error path which is wrong
for dt-probed devices
- is requires gpiod_get_direction without real need.
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
