Re: [PATCH] serial: mctrl_gpio: Fix build warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Fabio,

On Tue, Mar 10, 2015 at 12:23:18PM -0300, Fabio Estevam wrote:
> Fix the following build warnings:
> 
> drivers/tty/serial/serial_mctrl_gpio.c: In function 'mctrl_gpio_init':
> drivers/tty/serial/serial_mctrl_gpio.c:110:4: warning: return makes pointer from integer without a cast
>     return PTR_ERR(gpios->gpio[i]);
>     ^
> /home/build/work/batch/drivers/tty/serial/serial_mctrl_gpio.c:90:6: warning: unused variable 'err' [-Wunused-variable]
>   int err;
>       ^
> 
> Return ERR_CAST and remove the unused 'err' variable to fix them. 
> 
> Reported-by: Olof's autobuilder <build@xxxxxxxxx>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
Same here as for the imx uart patch. I even noticed this problem and
somehow managed to post the unfixed version. :-(

Maybe add

Fixes: 1d267ea6539f ("serial: mctrl-gpio: simplify init routine")

and also:

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux