* Zhong, Huiquan <huiquan.zhong@xxxxxxxxx> [150309 19:27]: > Yes, I add pm_runtime_irq_safe() too, but in 8250_dw.c there are sleep() in intel lpss runtime_resume function, So if using spin_lock, there are lots of issue. > > That is what I want said, we can't restrict there are no sleep function in runtime PM callback. Yes agreed, we should not need to use pm_runtime_irq_safe() in general for drivers at all. Having pm_runtime calls in the irq handler probably means the driver should just do the handling in a bottom half anyways. In many cases the driver does need to sleep on resume to because of the need to start up regulators. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
