On Mon, Mar 09, 2015 at 04:21:42PM +0800, Ken Xue wrote: > On Mon, 2015-03-09 at 10:01 +0200, Heikki Krogerus wrote: > > Hi, > > > > On Mon, Mar 09, 2015 at 08:40:10AM +0800, Ken Xue wrote: > > > tty:8250:add AMD UART support based on 8250_dw. > > > AMD CZ integrates Designware's UART IP with 32bit width registers. > > > APD(similar with LPSS) creates UART platform device based on ACPI > > > device AMD0020, and registers clk for this UART device. > > > > What exactly is AMD CZ? Is it a SoC? It would probable be good to > > explain it in the commit message. > > > > Maybe you could just say in your subject something like: > > "serial: 8250_dw: add support for AMD CZ" > > > > And the commit message would say this: > > "Add ACPI identifier for UART on AMD <what ever CZ means>." > > > > > Thanks. > How about this one? > > Subject: serial: 8250_dw: add support for AMD SOC Carrizo. > Add ACPI identifier for UART on AMD SOC Carrizo. Looks good to me, Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
