Hi Peter,
On Wed, Mar 4, 2015 at 6:24 PM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:
> --- a/drivers/tty/serial/earlycon.c
> +++ b/drivers/tty/serial/earlycon.c
> @@ -69,6 +69,7 @@ static void __init earlycon_init(struct earlycon_device *device,
> const char *name)
> {
> struct console *earlycon = device->con;
> + struct uart_port *port = &device->port;
> const char *s;
> size_t len;
>
> @@ -82,6 +83,16 @@ static void __init earlycon_init(struct earlycon_device *device,
> len = s - name;
> strlcpy(earlycon->name, name, min(len + 1, sizeof(earlycon->name)));
> earlycon->data = &early_console_dev;
> +
> + if (port->iotype == UPIO_MEM || port->iotype == UPIO_MEM32)
> + pr_info("Early serial console at MMIO%s 0x%llx (options '%s')\n",
> + (port->iotype == UPIO_MEM32) ? "32" : "",
> + (unsigned long long)port->mapbase,
I know you're just moving this piece of code around, but mapbase is a
resource_size_t (it should actually be phys_addr_t, which probably didn't
exist in 2007), so it should be printed using %pa and passing a reference,
instead of %llx and using a cast.
> + device->options);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
