Re: [PATCH] serial: core: Fix iotype userspace breakage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 1, 2015 at 7:18 AM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:
> commit 3ffb1a8193bea ("serial: core: Add big-endian iotype")
> re-numbered userspace-dependent values; ioctl(TIOCSSERIAL) can
> assign the port iotype (which is expected to match the selected
> i/o accessors), so iotype values must not be changed.
>
> Cc: Kevin Cernekee <cernekee@xxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # 3.19+
> Signed-off-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
> ---
>  include/linux/serial_core.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index a3fd182..85fdd89 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -147,9 +147,9 @@ struct uart_port {
>  #define UPIO_HUB6              (1)                     /* Hub6 ISA card */
>  #define UPIO_MEM               (2)                     /* 8b MMIO access */
>  #define UPIO_MEM32             (3)                     /* 32b little endian */
> -#define UPIO_MEM32BE           (4)                     /* 32b big endian */
> -#define UPIO_AU                        (5)                     /* Au1x00 and RT288x type IO */
> -#define UPIO_TSI               (6)                     /* Tsi108/109 type IO */
> +#define UPIO_AU                        (4)                     /* Au1x00 and RT288x type IO */
> +#define UPIO_TSI               (5)                     /* Tsi108/109 type IO */
> +#define UPIO_MEM32BE           (6)                     /* 32b big endian */

Whoops, I had no clue userland cared about these... thanks for the fix.

Reviewed-by: Kevin Cernekee <cernekee@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux