Re: Incorrect set_ldisc() for mxs-auart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 12, 2014 at 3:26 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> Janusz,
>
> Since commit 36a262782b04 ("serial: mxs-auart: enable PPS support")
> the following build warning is seen:
>
> drivers/tty/serial/mxs-auart.c:962:2: warning: initialization from
> incompatible pointer type
>   .set_ldisc      = mxs_auart_set_ldisc,
>   ^
> drivers/tty/serial/mxs-auart.c:962:2: warning: (near initialization
> for 'mxs_auart_ops.set_ldisc')
>
> The mxs_auart_set_ldisc() function should look like this:
>
> static void mxs_auart_set_ldisc(struct uart_port *port, struct
> ktermios *termios)
>
> instead of
>
> static void mxs_auart_set_ldisc(struct uart_port *port, int new)
>
> Please fix it.

Ok, so the fix is simple and I will submit it. Please give it a test.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux