On 09/05/2014 10:44 AM, Andre Przywara wrote:
> On 02/09/14 19:19, Peter Hurley wrote:
>> On 08/29/2014 12:13 PM, Andre Przywara wrote:
>>> +static void
>>> +sbsa_uart_set_termios(struct uart_port *port, struct ktermios *termios,
>>> + struct ktermios *old)
>>> +{
>>> + unsigned long flags;
>>> + unsigned int baud = 115200;
>>> +
>>> + spin_lock_irqsave(&port->lock, flags);
>> ^^^^^^^^^^^^^^^^^
>>
>> Can be spin_lock_irq(&port->lock) here.
>
> Why is this? Because this code cannot be called with interrupts already
> off?
Yes.
> This would apply to the original PL011 driver also then?
Also, yes.
I mentioned it because new code should use the spin_lock_irq() flavor
[primarily as a visual aid for driver authors].
Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
