On Monday 16 June 2014 09:17:11 Peter Hurley wrote: > tty_wait_until_sent_from_close() drops the tty lock while waiting > for the tty driver to finish sending previously accepted data (ie., > data remaining in its write buffer and transmit fifo). > > However, dropping the tty lock is a hold-over from when the tty > lock was system-wide; ie., one lock for all ttys. > > Since commit 89c8d91e31f267703e365593f6bfebb9f6d2ad01, > 'tty: localise the lock', dropping the tty lock has not been necessary. > > CC: Karsten Keil <isdn@xxxxxxxxxxxxxx> > CC: linuxppc-dev@xxxxxxxxxxxxxxxx > Signed-off-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> I don't understand the second half of the changelog, it doesn't seem to fit here: there deadlock that we are trying to avoid here happens when the *same* tty needs the lock to complete the function that sends the pending data. I don't think we do still do that any more, but it doesn't seem related to the tty lock being system-wide or not. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
