On Wed, May 14, 2014 at 03:55:32PM +0100, Daniel Thompson wrote: > The behaviour of the UART poll_put_char infrastructure is inconsistent > with respect to linefeed conversions. This in turn leads to difficulty > using kdb on serial ports that are not also consoles > (e.g. console=ttyAMA0,115200 kgdboc=ttyAMA1,115200). > > The following drivers automatically convert '\n' to '\r\n' inside their > own poll functions but the remaining seventeen do not: > > serial8250, cpm, pch_uart, serial_pxa, serial_txx9, > > This can be made fully consistent but performing the conversion in > uart_poll_put_char(). A similar conversion is already made inside > uart_console_write() but it is optional for drivers to use this > function. Fortunately we can be confident the translation is safe > because the (very common) 8250 already does this translation. > > Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > Cc: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> > Cc: Pantelis Antoniou <panto@xxxxxxxxxxx> > Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > Cc: Joe Schultz <jschultz@xxxxxxxxxxx> > Cc: Loic Poulain <loic.poulain@xxxxxxxxx> > Cc: Kyle McMartin <kyle@xxxxxxxxxxxxx> > Cc: Stephen Warren <swarren@xxxxxxxxxx> > Cc: Ingo Molnar <mingo@xxxxxxx> > Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > Cc: Grant Likely <grant.likely@xxxxxxxxxx> > Cc: Rob Herring <rob.herring@xxxxxxxxxxx> > Cc: Jingoo Han <jg1.han@xxxxxxxxxxx> > Cc: Christophe Leroy <christophe.leroy@xxxxxx> > --- > drivers/tty/serial/8250/8250_core.c | 5 ----- This patch doesn't apply to my tty-next branch anymore, as it seems that part of it is already there, right? Can you respin this whole series and resend? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
