On Mon, Apr 28, 2014 at 4:24 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: > On Sat, Apr 26, 2014 at 1:29 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > > Thanks for finding these. I missed them in my build tests. This should fix them: > > diff --git a/drivers/tty/serial/8250/8250_early.c > b/drivers/tty/serial/8250/8250_early.c > index e83c9db..2094c3b 100644 > --- a/drivers/tty/serial/8250/8250_early.c > +++ b/drivers/tty/serial/8250/8250_early.c > @@ -156,6 +156,11 @@ static int __init early_serial8250_setup(struct > earlycon_device *device, > EARLYCON_DECLARE(uart8250, early_serial8250_setup); > EARLYCON_DECLARE(uart, early_serial8250_setup); > > +int __init setup_early_serial8250_console(char *cmdline) > +{ > + return setup_earlycon(cmdline, "uart8250", early_serial8250_setup); > +} > + > int serial8250_find_port_for_earlycon(void) > { > struct earlycon_device *device = early_device; that only handle "uart8250,", may need to add more lines to handle "uart," +int __init setup_early_serial8250_console(char *cmdline) +{ + char *options; + options = strstr(cmdline, "uart8250,"); + if (options) + return setup_earlycon(cmdline, "uart8250", early_serial8250_setup); + + options = strstr(cmdline, "uart,"); + if (options) + return setup_earlycon(cmdline, "uart", early_serial8250_setup); + + return 0; +} + Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html