On Fri, 25 Apr 2014, Charles Coldwell wrote: > On Thu, 24 Apr 2014, jon@xxxxxxxxxx wrote: > > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > > new file mode 100644 > > index 0000000..ed139f5 > > --- /dev/null > > +++ b/drivers/tty/serial/sc16is7xx.c > > > + > > +/* SC16IS7XX register definitions */ > > +#define SC16IS7XX_RHR_REG (0x00) /* RX FIFO */ > > +#define SC16IS7XX_THR_REG (0x00) /* TX FIFO */ > > +#define SC16IS7XX_IER_REG (0x01) /* Interrupt enable */ > > +#define SC16IS7XX_IIR_REG (0x02) /* Interrupt Identification */ > > +#define SC16IS7XX_FCR_REG (0x02) /* FIFO control */ > > +#define SC16IS7XX_LCR_REG (0x03) /* Line Control */ > > +#define SC16IS7XX_MCR_REG (0x04) /* Modem Control */ > > +#define SC16IS7XX_LSR_REG (0x05) /* Line Status */ > > +#define SC16IS7XX_MSR_REG (0x06) /* Modem Status */ > > +#define SC16IS7XX_SPR_REG (0x07) /* Scratch Pad */ > > Isn't this a lot of duplication? Actually, the whole thing seems like duplication to me. The SC16IS7X0 parts are designed to be 16550-compatible (hence the duplication in the register map), and so I would vote for putting the driver into the drivers/tty/serial/8250 framework. There's really not much difference between these parts and other 16550 parts except that they are reached over the SPI/I2C bus. -- Charles M. Coldwell, W1CMC "Turn on, log in, tune out" Belmont, Massachusetts, New England (FN42jj) GPG ID: 852E052F GPG FPR: 77E5 2B51 4907 F08A 7E92 DE80 AFA9 9A8F 852E 052F -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
