Fri, 25 Apr 2014 09:21:26 -0400 (EDT) от Charles Coldwell <coldwell@xxxxxxxxx>:
> On Thu, 24 Apr 2014, jon@xxxxxxxxxx wrote:
>
> > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> > new file mode 100644
> > index 0000000..ed139f5
> > --- /dev/null
> > +++ b/drivers/tty/serial/sc16is7xx.c
>
> > +
> > +/* SC16IS7XX register definitions */
> > +#define SC16IS7XX_RHR_REG (0x00) /* RX FIFO */
> > +#define SC16IS7XX_THR_REG (0x00) /* TX FIFO */
> > +#define SC16IS7XX_IER_REG (0x01) /* Interrupt enable */
> > +#define SC16IS7XX_IIR_REG (0x02) /* Interrupt Identification */
> > +#define SC16IS7XX_FCR_REG (0x02) /* FIFO control */
> > +#define SC16IS7XX_LCR_REG (0x03) /* Line Control */
> > +#define SC16IS7XX_MCR_REG (0x04) /* Modem Control */
> > +#define SC16IS7XX_LSR_REG (0x05) /* Line Status */
> > +#define SC16IS7XX_MSR_REG (0x06) /* Modem Status */
> > +#define SC16IS7XX_SPR_REG (0x07) /* Scratch Pad */
>
> Isn't this a lot of duplication? We have already in
>
> /*
> * include/linux/serial_reg.h
> *
> #define UART_RX 0 /* In: Receive buffer */
> #define UART_TX 0 /* Out: Transmit buffer */
> #define UART_IER 1 /* Out: Interrupt Enable Register */
> #define UART_IIR 2 /* In: Interrupt ID Register */
> #define UART_FCR 2 /* Out: FIFO Control Register */
> #define UART_LCR 3 /* Out: Line Control Register */
> #define UART_MCR 4 /* Out: Modem Control Register */
> #define UART_LSR 5 /* In: Line Status Register */
> #define UART_MSR 6 /* In: Modem Status Register */
> #define UART_SCR 7 /* I/O: Scratch Register */
>
> and the bit definitions, as well.
And it would be nice to have a small changelog,
because it is unclear what has changed with version 6.
---
��.n��������+%������w��{.n�����{��ǫ����{ay� ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��
