On Tue, Feb 18, 2014 at 10:09:43AM +0000, Etched Pixels wrote: > Mark Brown <broonie@xxxxxxxxxx> wrote: > > It's a very real problem which affects actual kernels that distro style > > users are building. > Only because you persist in trying to keep the old static minor > numbers even though they are not needed by anything in the real world > that will ever run such kernels. Also only because you are apparently > too slack to bother to check whether the driver matches the platform or > there is an device tree node before registering it even though that's > trivial to code and is already done by some other platforms and serial > drivers just fine. > It's a core code "problem" that is invented by refusing to do the simple > trivial fixes in the ARM tree. Please clean up your own poop instead of > trying to shovel it into the street. Please try to avoid this sort of misdirected yelling, it's not helping anything to complain that people are following the recommendations of the maintainer or to demand that this somehow gets hacked around in arch/ when we're trying to convince all the architectures to get their drivers merged into subsystem trees so they're reviewed by the subsystem maintainers. If you have some examples of better practice for serial device registration that you'd like to identify that'd be helpful, but what you're doing here is making disparaging remarks and telling people to adopt bad practices because someone else made a mistake a decade ago. That is how problems like this get created in the first place. > And the proposed change set is buggy as hell - because we register things > like 8250 devices at least four ways on the same x86 machine all of which > could in theory occur in parallel. Then you need to convince Greg of that. The most recent set of patches are exactly what he asked for.
Attachment:
signature.asc
Description: Digital signature
