On Fri, Jan 24, 2014 at 06:09:41PM +0100, Markus Pargmann wrote:
> Currently the info message about a missing wakeirq for uart is printed
> every time the serial driver's startup function is called. This happens
> multiple times and not just once.
>
> This patch moves the infomessage to the probe function to display it
> only once.
>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/omap-serial.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index fa511eb..2051581 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -738,9 +738,6 @@ static int serial_omap_startup(struct uart_port *port)
> return retval;
> }
> disable_irq(up->wakeirq);
> - } else {
> - dev_info(up->port.dev, "no wakeirq for uart%d\n",
> - up->port.line);
> }
>
> dev_dbg(up->port.dev, "serial_omap_startup+%d\n", up->port.line);
> @@ -1687,6 +1684,9 @@ static int serial_omap_probe(struct platform_device *pdev)
> up->port.iotype = UPIO_MEM;
> up->port.irq = uartirq;
> up->wakeirq = wakeirq;
> + if (!up->wakeirq)
> + dev_info(up->port.dev, "no wakeirq for uart%d\n",
> + up->port.line);
>
> up->port.regshift = 2;
> up->port.fifosize = 64;
> --
> 1.8.5.2
>
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
