On Wed, Feb 12, 2014 at 10:47:42PM +0800, Barry Song wrote: > 2014-02-12 22:37 GMT+08:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > > On Wed, Feb 12, 2014 at 10:26:32PM +0800, Barry Song wrote: > >> 2014-02-12 22:19 GMT+08:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > >> > On Wed, Feb 12, 2014 at 10:08:44PM +0800, Barry Song wrote: > >> >> From: Barry Song <Baohua.Song@xxxxxxx> > >> >> > >> >> Signed-off-by: Barry Song <Baohua.Song@xxxxxxx> > >> >> --- > >> >> drivers/tty/serial/sirfsoc_uart.c | 3 ++- > >> >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> >> > >> >> diff --git a/drivers/tty/serial/sirfsoc_uart.c b/drivers/tty/serial/sirfsoc_uart.c > >> >> index 49a2ffd..7079b5c 100644 > >> >> --- a/drivers/tty/serial/sirfsoc_uart.c > >> >> +++ b/drivers/tty/serial/sirfsoc_uart.c > >> >> @@ -1,7 +1,8 @@ > >> >> /* > >> >> * Driver for CSR SiRFprimaII onboard UARTs. > >> >> * > >> >> - * Copyright (c) 2011 Cambridge Silicon Radio Limited, a CSR plc group company. > >> >> + * Copyright (c) 2011 - 2014 Cambridge Silicon Radio Limited, a CSR plc group > >> >> + * company. > >> > > >> > I do not see contributions from csr for all of these years, so no, this > >> > is not allowed. Please go talk with your corporate lawyer if you have > >> > questions about how/when to update the copyright of your files, as I > >> > don't think they would agree that this change is correct. > >> > >> Greg, as i run "git log sirfsoc_uart.c", there are commits from csr > >> for touched file from 2011 to 2014: > >> > >> 2011: > >> commit 161e773cbd0c3d1b5b8cc00602e1f72de61ed4f7 > >> Author: Rong Wang <Rong.Wang@xxxxxxx> > >> Date: Thu Nov 17 23:17:04 2011 +0800 > >> > >> 2012: > >> commit 5425e03f97d1e5847372aae0b895d8d1c9bf2741 > >> Author: Barry Song <Baohua.Song@xxxxxxx> > >> Date: Tue Dec 25 17:32:04 2012 +0800 > >> > >> 2013: > >> commit ac4ce718893c546f7a2d34ab55a8f75842399f86 > >> Author: Barry Song <Baohua.Song@xxxxxxx> > >> Date: Wed Jan 16 14:49:27 2013 +0800 > >> ... > >> commit 59f8a62c25b9c2a53e7c359ba9ca611639a4c0b0 > >> Author: Qipan Li <Qipan.Li@xxxxxxx> > >> Date: Sat Sep 21 09:02:10 2013 +0800 > >> > >> > >> 2014: > >> commit 388faf9ffdaf92c81243514a2dd4c6ce04d28874 > >> Author: Qipan Li <Qipan.Li@xxxxxxx> > >> Date: Fri Jan 3 15:44:07 2014 +0800 > >> > >> commit df8d4aa0d84995bf7fb8d8a978a0d67fff6ca53a > >> Author: Qipan Li <Qipan.Li@xxxxxxx> > >> Date: Fri Jan 3 15:44:08 2014 +0800 > > > > And do all of these changes fall under the "copyright is allowed to be > > updated" rule that your corporation follows? Again, please talk to your > > corporate lawyer about this, as the rules I have been told to follow do > > not seem to match up here. I'll be glad to discuss this with your > > lawyer through email if they have further questions. > > ok. it seems it is very confused now. i was told we can update > copyright years once we have any valid change in one module. > i will talk with the lawyer of csr. BTW, would you like to share your > idea why it is not ok here since we have changes for all of 2011, > 2012, 2013 and 2014. i am not debating this with you, i just want to > collect your input so that i can output to csr lawyer and customers. Well, your 2012 change doesn't seem to be "significant" to warrent a normal copyright update, but the update is usually "less strict" than an original mark, so that might be ok, now that I review these closer. But I'd still prefer to get the opinion of your lawyer about this. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
