Re: [PATCH 1/2] serial: sh-sci: Fix cast warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, February 05, 2014 7:09 AM, Laurent Pinchart wrote:
> 
> Hi Jingoo,
> 
> Thank you for the patch.
> 
> On Tuesday 04 February 2014 15:55:41 Jingoo Han wrote:
> > Fix the following compile warning about cast to pointer from
> > integer of different size.
> >
> > drivers/tty/serial/sh-sci.c:2021:19: warning: cast to pointer from integer
> > of different size [-Wint-to-pointer-cast]
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> > ---
> >  drivers/tty/serial/sh-sci.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index be33d2b..61729d4 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -2018,7 +2018,7 @@ static int sci_remap_port(struct uart_port *port)
> >  		 * need to do any remapping, just cast the cookie
> >  		 * directly.
> >  		 */
> > -		port->membase = (void __iomem *)port->mapbase;
> > +		port->membase = (void __iomem *)(unsigned long)port->mapbase;
> 
> What about casting to uintptr_t instead of unsigned long ?

OK, I see.
I will use it and send v2 patch, soon.
I really appreciate your comment. :-)
Thank you.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux