On Thursday 16 January 2014, Yao Yuan wrote: > > This part will result in a slight increase in data size even if dma > > support is turned off at compile time. > > > > Yes, someone also want me define a independent struct for dma and allocate the memory when dma be use. > But I think this way will add a more memory access time, like a->b->c and a->c. And the variable > about dma is just a few bytes but used frequently. So I think I'd better define the variable about dma in lpuart_port struct. I agree. Just leave it unconditionally in here to make the code simpler. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html