On Wed, Jan 15, 2014 at 11:17:07AM +0000, Arnd Bergmann wrote: > On Wednesday 15 January 2014 11:05:37 Mark Rutland wrote: > > On Wed, Jan 15, 2014 at 05:21:05AM +0000, Yuan Yao wrote: > > > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt > > > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.txt > > > @@ -4,11 +4,24 @@ Required properties: > > > - compatible : Should be "fsl,<soc>-lpuart" > > > - reg : Address and length of the register set for the device > > > - interrupts : Should contain uart interrupt > > > +- clocks : from common clock binding: handle to uart clock > > > +- clock-names : from common clock binding: Shall be "ipg" > > > > Why are these now requried if they weren't previously? That breaks old > > dts. I can't see any new code touching clocks. Was this an old but > > undocumented requirement? > > It was previously required but not documented. I asked Yuan Yao to > add the text to the binding along with the new "dmas" addition. Ok. > > It would have been cleaner to do this as a separate patch, but at > the very least it should be mentioned in the changelog. Having it in the changelog would be nice. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
