Hi, Arnd > Arnd Bergmann wrote: > > > @@ -131,6 +158,10 @@ static struct of_device_id lpuart_dt_ids[] = { > > }; MODULE_DEVICE_TABLE(of, lpuart_dt_ids); > > > > +static int lpuart_dma_tx(struct lpuart_port *sport, unsigned long > > +count); static int lpuart_dma_rx(struct lpuart_port *sport); static > > +void lpuart_prepare_tx(struct lpuart_port *sport); > > + > > static void lpuart_stop_tx(struct uart_port *port) { > > unsigned char temp; > > Coding style: Please try to avoid forward declarations for "static" > functions. > Instead, reorder the code in a way that they are not needed. > > Arnd > I need the functions like this: Static A() { if(condition) B(); } Static B() { callback:C(); } Static C() { if(condition) A(); } So, it's hard to avoid forward declarations for "static" functions. I'm very glad for a better way. ��.n��������+%������w��{.n�����{��ǫ����{ay�ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��