On Thu, 2013-12-19 at 13:35 +0400, Sergei Ianovich wrote: > Hi Heikki, > > On Thu, 2013-12-19 at 10:51 +0200, Heikki Krogerus wrote: > > I noticed one more thing. I'm sorry about commenting this late. > > > > Since you set the type PORT_XSCALE, don's you want to use > > UPF_FIXED_TYPE flag instead of the UPF_SKIP_TEST here? Otherwise the > > type will just get overridden and autoconfig() will be executed. > > UPF_FIXED_PORT was my first guess. However, it didn't work. > > I've also tried to do ioremap in serial_pxa_probe instead of using > UPF_IOREMAP. This didn't work as well. I didn't clarify properly. UPF_SKIP_TEST skips only the loopback test. This test could work on PXA, but requires PXA-specific pre-initialization. There are more test after the loopback one, which will fail if we are not on PXA. So I decided that skipping it is easier than tricky rewriting of autoconfig(). -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
