On Mon, Dec 09, 2013 at 10:38:15AM +0200, Heikki Krogerus wrote: > Hi, > > > + return 0; > > + > > + err_clk: > > + clk_unprepare(data->clk); > > + err_free_clk: > > + devm_clk_put(&pdev->dev, data->clk); > > + err_free: > > + devm_kfree(&pdev->dev, data); > > And there labels could be dropped. This should really be fixed. Explicitly releasing devm_* allocated resources invalidates the whole idea of the devm functions. People looking for templates shouldn't find examples for this in the kernel. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
