On Sun, Oct 06, 2013 at 12:15:46PM -0700, Greg Kroah-Hartman wrote: > On Sun, Oct 06, 2013 at 07:37:43AM -0700, Guenter Roeck wrote: > > On Sun, Oct 06, 2013 at 01:09:56PM +0200, Sascha Hauer wrote: > > > On Thu, Oct 03, 2013 at 11:44:45AM -0700, Greg Kroah-Hartman wrote: > > > > On Wed, Oct 02, 2013 at 09:56:11PM -0700, Guenter Roeck wrote: > > > > > Hi all, > > > > > > > > > > Commit f7d2c0bbdb (serial: i.MX: evaluate linux,stdout-path property) adds a > > > > > call to add_preferred_console() into drivers/tty/serial/imx.c. The file can be > > > > > built as module, yet add_preferred_console() is not exported on any platform. > > > > > This is one reason why arm:allmodconfig fails to build on the upstream kernel. > > > > > > > > > > What is the best solution ? Should imx.c not be buildable as module anymore ? > > > > > > > > Sascha, I'll have to revert this patch unless you wish to fix it in a > > > > different way? > > > > > > Do you think exporting add_preferred_console() would be acceptable? If > > > yes, that would be my preferred solution. > > > > > Difficult to imagine that a console driver can be a loadable module. > > Unload it while the system is running and then what ? > > Ah man, you spoiled the punch line I was setting Sascha up for! :) I can hardly feel that punch as I'm just about to leave town for vacation ;) > > > Why does this driver have to be buildable as module anyway ? If that is really > > a MUST, an alternative might be to only call add_preferred_console() if it is not > > built as module. > > Yes, that's the correct solution, _if_ this has to be a module. I don't think it has to be buildable as module. I attached a patch disabling module build. Fabio, I'm not available until the beginning of next week. Could you keep an eye on this? Thanks Sascha 8<--------------------------------------------------------- >From 66197e3bd3d1f4000a637e6960c340d7aa0ccf1f Mon Sep 17 00:00:00 2001 From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Date: Mon, 7 Oct 2013 08:46:46 +0200 Subject: [PATCH] serial: i.MX: do not allow to build as module Commit f7d2c0bbdb (serial: i.MX: evaluate linux,stdout-path property) adds a call to add_preferred_console() into drivers/tty/serial/imx.c. The file can be built as module, yet add_preferred_console() is not exported. Fix the build failure by disabling module build for the i.MX driver. Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> --- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index febd45c..b8c5f36 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -551,7 +551,7 @@ config BFIN_UART3_CTSRTS Enable hardware flow control in the driver. config SERIAL_IMX - tristate "IMX serial port support" + boot "IMX serial port support" depends on ARCH_MXC select SERIAL_CORE select RATIONAL -- 1.8.4.rc3 -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
