On Thu, Oct 03, 2013 at 11:44:45AM -0700, Greg Kroah-Hartman wrote: > On Wed, Oct 02, 2013 at 09:56:11PM -0700, Guenter Roeck wrote: > > Hi all, > > > > Commit f7d2c0bbdb (serial: i.MX: evaluate linux,stdout-path property) adds a > > call to add_preferred_console() into drivers/tty/serial/imx.c. The file can be > > built as module, yet add_preferred_console() is not exported on any platform. > > This is one reason why arm:allmodconfig fails to build on the upstream kernel. > > > > What is the best solution ? Should imx.c not be buildable as module anymore ? > > Sascha, I'll have to revert this patch unless you wish to fix it in a > different way? Do you think exporting add_preferred_console() would be acceptable? If yes, that would be my preferred solution. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
