RE: [PATCH 3/7] serial: bfin_uart: Remove casting the return value which is a void pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Sonic Zhang<sonic.zhang@xxxxxxxxxx>

>-----Original Message-----
>From: Jingoo Han [mailto:jg1.han@xxxxxxxxxxx]
>Sent: Monday, September 09, 2013 1:09 PM
>To: 'Greg Kroah-Hartman'
>Cc: linux-serial@xxxxxxxxxxxxxxx; Zhang, Sonic; 'Jingoo Han'
>Subject: [PATCH 3/7] serial: bfin_uart: Remove casting the return value which is a
>void pointer
>
>Casting the return value which is a void pointer is redundant.
>The conversion from void pointer to any other pointer type is guaranteed by the C
>programming language.
>
>Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
>---
> drivers/tty/serial/bfin_uart.c |   15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
>diff --git a/drivers/tty/serial/bfin_uart.c b/drivers/tty/serial/bfin_uart.c index
>3c75e8e..74749a6 100644
>--- a/drivers/tty/serial/bfin_uart.c
>+++ b/drivers/tty/serial/bfin_uart.c
>@@ -1240,7 +1240,7 @@ static int bfin_serial_probe(struct platform_device *pdev)
>                        */
> #endif
>               ret = peripheral_request_list(
>-                      (unsigned short *)dev_get_platdata(&pdev->dev),
>+                      dev_get_platdata(&pdev->dev),
>                       DRIVER_NAME);
>               if (ret) {
>                       dev_err(&pdev->dev,
>@@ -1358,8 +1358,7 @@ static int bfin_serial_probe(struct platform_device *pdev)
> out_error_unmap:
>               iounmap(uart->port.membase);
> out_error_free_peripherals:
>-              peripheral_free_list(
>-                      (unsigned short *)dev_get_platdata(&pdev->dev));
>+              peripheral_free_list(dev_get_platdata(&pdev->dev));
> out_error_free_mem:
>               kfree(uart);
>               bfin_serial_ports[pdev->id] = NULL;
>@@ -1377,8 +1376,7 @@ static int bfin_serial_remove(struct platform_device *pdev)
>       if (uart) {
>               uart_remove_one_port(&bfin_serial_reg, &uart->port);
>               iounmap(uart->port.membase);
>-              peripheral_free_list(
>-                      (unsigned short *)dev_get_platdata(&pdev->dev));
>+              peripheral_free_list(dev_get_platdata(&pdev->dev));
>               kfree(uart);
>               bfin_serial_ports[pdev->id] = NULL;
>       }
>@@ -1432,8 +1430,8 @@ static int bfin_earlyprintk_probe(struct platform_device
>*pdev)
>               return -ENOENT;
>       }
>
>-      ret = peripheral_request_list(
>-              (unsigned short *)dev_get_platdata(&pdev->dev), DRIVER_NAME);
>+      ret = peripheral_request_list(dev_get_platdata(&pdev->dev),
>+                                      DRIVER_NAME);
>       if (ret) {
>               dev_err(&pdev->dev,
>                               "fail to request bfin serial peripherals\n"); @@ -1463,8
>+1461,7 @@ static int bfin_earlyprintk_probe(struct platform_device *pdev)
>       return 0;
>
> out_error_free_peripherals:
>-      peripheral_free_list(
>-              (unsigned short *)dev_get_platdata(&pdev->dev));
>+      peripheral_free_list(dev_get_platdata(&pdev->dev));
>
>       return ret;
> }
>--
>1.7.10.4
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux